egullickson/motovaultpro
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove license plate fallback from VIN field (#39) #40

Merged
egullickson merged 1 commits from issue-39-fix-vin-field-fallback into main 2026-01-16 02:35:04 +00:00
Conversation 0 Commits 1 Files Changed 1
+1 -2
egullickson commented 2026-01-16 02:29:58 +00:00
Owner
Copy Link
Copy Source

Summary

Fixes #39

The VIN Number field in VehicleDetailPage.tsx incorrectly displayed the license plate value when VIN was empty. This was confusing because the field label says "VIN Number" but showed a license plate.

Changes

  • Removed || vehicle.licensePlate fallback from VIN field (line 390)
  • Removed isRequired prop since VIN is optional (vehicles can have license plate only)
  • VIN field now shows "Not provided" for missing values (handled by DetailField component)

Consistency

  • Desktop detail view now matches mobile behavior (VehicleDetailMobile.tsx already handles VIN correctly)
  • License plate continues to be displayed in its own dedicated field

Test Plan

  • View vehicle detail with VIN - should show VIN value
  • View vehicle detail without VIN - should show "Not provided"
  • License plate field should always show license plate (unchanged)
  • Mobile and desktop views behave consistently

Acceptance Criteria

  • VIN Number field shows only VIN value (or empty state when missing)
  • License plate displayed in its own field
  • Desktop and mobile detail views behave consistently
  • Lint and type-check pass

🤖 Generated with Claude Code

## Summary Fixes #39 The VIN Number field in VehicleDetailPage.tsx incorrectly displayed the license plate value when VIN was empty. This was confusing because the field label says "VIN Number" but showed a license plate. ### Changes - Removed `|| vehicle.licensePlate` fallback from VIN field (line 390) - Removed `isRequired` prop since VIN is optional (vehicles can have license plate only) - VIN field now shows "Not provided" for missing values (handled by DetailField component) ### Consistency - Desktop detail view now matches mobile behavior (`VehicleDetailMobile.tsx` already handles VIN correctly) - License plate continues to be displayed in its own dedicated field ## Test Plan - [ ] View vehicle detail with VIN - should show VIN value - [ ] View vehicle detail without VIN - should show "Not provided" - [ ] License plate field should always show license plate (unchanged) - [ ] Mobile and desktop views behave consistently ## Acceptance Criteria - [x] VIN Number field shows only VIN value (or empty state when missing) - [x] License plate displayed in its own field - [x] Desktop and mobile detail views behave consistently - [x] Lint and type-check pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)
egullickson added 1 commit 2026-01-16 02:29:59 +00:00
fix: remove license plate fallback from VIN field (refs #39)
Deploy to Staging / Build Images (pull_request) Successful in 2m46s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 38s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
fbc0186ea6 
The VIN Number field incorrectly showed license plate when VIN was empty.
Now displays "Not provided" for missing VIN values, matching mobile behavior.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
egullickson merged commit f325ff49d0 into main 2026-01-16 02:35:04 +00:00
egullickson deleted branch issue-39-fix-vin-field-fallback 2026-01-16 02:35:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#40