egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Migrate Gemini SDK to google-genai (#231) #236

Merged
egullickson merged 8 commits from issue-231-migrate-gemini-sdk-google-genai into main 2026-03-01 04:08:11 +00:00
Conversation 0 Commits 8 Files Changed 11 +227 -214
egullickson commented 2026-02-28 17:22:58 +00:00
Owner
Copy Link

Fixes #231
Fixes #232
Fixes #233
Fixes #234
Fixes #235

Summary

Migrate OCR service from deprecated google-cloud-aiplatform / vertexai.generative_models SDK to google-genai package. Enable Google Search grounding for VIN decode to improve accuracy.

Changes

  • M1 (#232): Swap google-cloud-aiplatform>=1.40.0 to google-genai>=1.0.0 in requirements.txt
  • M2 (#233): Migrate GeminiEngine -- _get_model() to _get_client(), client-per-call pattern, Google Search grounding for VIN decode, uppercase schema types
  • M3 (#234): Migrate MaintenanceReceiptExtractor -- same pattern, fix RuntimeError bug to use GeminiUnavailableError
  • M4 (#235): Update test mocks -- engine._client/engine._model_name pattern, clean up dead code
  • M5: Doc-sync on affected CLAUDE.md files and config.py comment

Test Results

  • Docker build: SUCCESS
  • 18/18 gemini engine tests: PASS
  • All VIN decode tests: PASS (unchanged)
  • All manual extractor tests: PASS (unchanged)

Remaining Verification

  • Deploy to staging and decode VIN 1G1YE2D32P5602473 to confirm correct 2023 Corvette data with Google Search grounding
Fixes #231 Fixes #232 Fixes #233 Fixes #234 Fixes #235 ## Summary Migrate OCR service from deprecated `google-cloud-aiplatform` / `vertexai.generative_models` SDK to `google-genai` package. Enable Google Search grounding for VIN decode to improve accuracy. ### Changes - **M1 (#232)**: Swap `google-cloud-aiplatform>=1.40.0` to `google-genai>=1.0.0` in requirements.txt - **M2 (#233)**: Migrate `GeminiEngine` -- `_get_model()` to `_get_client()`, client-per-call pattern, Google Search grounding for VIN decode, uppercase schema types - **M3 (#234)**: Migrate `MaintenanceReceiptExtractor` -- same pattern, fix RuntimeError bug to use GeminiUnavailableError - **M4 (#235)**: Update test mocks -- `engine._client`/`engine._model_name` pattern, clean up dead code - **M5**: Doc-sync on affected CLAUDE.md files and config.py comment ### Test Results - Docker build: SUCCESS - 18/18 gemini engine tests: PASS - All VIN decode tests: PASS (unchanged) - All manual extractor tests: PASS (unchanged) ### Remaining Verification - Deploy to staging and decode VIN `1G1YE2D32P5602473` to confirm correct 2023 Corvette data with Google Search grounding
egullickson added 5 commits 2026-02-28 17:22:59 +00:00
feat: replace google-cloud-aiplatform with google-genai dependency (refs #232) 398d67304f 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: migrate GeminiEngine to google-genai SDK with Google Search grounding (refs #233) b7f472b3e8 
Replace vertexai.generative_models with google.genai client pattern.
Add Google Search grounding tool to VIN decode for improved accuracy.
Convert response schema types to uppercase per Vertex AI Schema spec.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: migrate MaintenanceReceiptExtractor to google-genai SDK (refs #234) 9f51e62b94 
Replace vertexai.generative_models with google.genai client pattern.
Fix pre-existing bug: raise GeminiUnavailableError instead of bare
RuntimeError for missing credentials. Add proper try/except blocks
matching GeminiEngine error handling pattern.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: update test mocks for google-genai SDK (refs #235) 1464a0e1af 
Replace engine._model/engine._generation_config mocks with
engine._client/engine._model_name. Update sys.modules patches
from vertexai to google.genai. Remove dead if-False branch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
docs: update CLAUDE.md references from Vertex AI to google-genai (refs #231)
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 8m4s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 24s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 9s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 9s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
96e1dde7b2 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
egullickson added 1 commit 2026-02-28 18:02:34 +00:00
fix: VIN Decoding timeouts and logic errors
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 3m33s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 52s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 9s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 8s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
936753fac2
egullickson added 1 commit 2026-02-28 18:59:11 +00:00
fix: remove unsupported AutomaticFunctionCallingConfig parameter (refs #231)
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 39s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 53s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 9s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 8s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
1add6c8240 
The installed google-genai version does not support max_remote_calls on
AutomaticFunctionCallingConfig, causing a pydantic validation error that
broke VIN decode on staging.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
egullickson added 1 commit 2026-03-01 03:17:00 +00:00
fix: revert unsupported AFC config and add diagnostic logging for VIN decode (refs #231)
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 12m33s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 52s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 9s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 8s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
56df5d48f3 
- Remove AutomaticFunctionCallingConfig(max_remote_calls=3) which caused
  pydantic validation error on the installed google-genai version
- Log full Gemini raw JSON response in OCR engine for debugging
- Add engine/transmission to backend raw values log
- Add hasTrim/hasEngine/hasTransmission to decode success log

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
egullickson merged commit 7e2bb9ef36 into main 2026-03-01 04:08:11 +00:00
egullickson deleted branch issue-231-migrate-gemini-sdk-google-genai 2026-03-01 04:08:12 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#236
Delete Branch "issue-231-migrate-gemini-sdk-google-genai"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?