egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: prompt vehicle selection on login after auto-downgrade (#60) #62

Merged
egullickson merged 5 commits from issue-60-vehicle-selection-prompt into main 2026-01-24 17:56:24 +00:00
Conversation 0 Commits 5 Files Changed 10 +228 -15
egullickson commented 2026-01-24 17:32:02 +00:00
Owner
Copy Link

Summary

When a user's subscription is auto-downgraded to free tier (via grace period expiration) and they have more than 2 vehicles, they are now prompted to select which 2 vehicles to keep active on their next login.

Fixes #60

Changes

Backend

  • Added GET /api/subscriptions/needs-vehicle-selection endpoint
  • Returns { needsSelection, vehicleCount, maxAllowed } based on:
    • User is on free tier
    • User has >2 active vehicles
    • User has no existing vehicle selections in tier_vehicle_selections

Frontend

  • Added useNeedsVehicleSelection hook with staleTime: 0 for fresh checks on login
  • Modified VehicleSelectionDialog with blocking prop:
    • Disables backdrop click and escape key
    • Hides Cancel button
    • Updated messaging for auto-downgrade scenario
  • Integrated in App.tsx after auth gate ready:
    • Checks if vehicle selection is needed
    • Shows blocking dialog until user selects vehicles
    • Calls existing downgrade API to save selections

Test Plan

  • Free tier user with 3+ vehicles, no selections: Dialog shown on login
  • Free tier user with 3+ vehicles, has selections: No dialog, app loads
  • Free tier user with 2 vehicles: No dialog, app loads
  • Pro/Enterprise tier user: No dialog, app loads
  • Dialog cannot be dismissed without selection
  • Selected vehicles saved correctly
  • Mobile + desktop responsive validation

Acceptance Criteria from Issue

  • Backend endpoint returns correct needsSelection status
  • VehicleSelectionDialog shown automatically on login when needed
  • Dialog cannot be dismissed without making selection
  • Selected vehicles saved correctly
  • Mobile + desktop responsive validation (manual testing needed)

🤖 Generated with Claude Code

## Summary When a user's subscription is auto-downgraded to free tier (via grace period expiration) and they have more than 2 vehicles, they are now prompted to select which 2 vehicles to keep active on their next login. Fixes #60 ## Changes ### Backend - Added `GET /api/subscriptions/needs-vehicle-selection` endpoint - Returns `{ needsSelection, vehicleCount, maxAllowed }` based on: - User is on free tier - User has >2 active vehicles - User has no existing vehicle selections in `tier_vehicle_selections` ### Frontend - Added `useNeedsVehicleSelection` hook with `staleTime: 0` for fresh checks on login - Modified `VehicleSelectionDialog` with `blocking` prop: - Disables backdrop click and escape key - Hides Cancel button - Updated messaging for auto-downgrade scenario - Integrated in `App.tsx` after auth gate ready: - Checks if vehicle selection is needed - Shows blocking dialog until user selects vehicles - Calls existing downgrade API to save selections ## Test Plan - [ ] Free tier user with 3+ vehicles, no selections: Dialog shown on login - [ ] Free tier user with 3+ vehicles, has selections: No dialog, app loads - [ ] Free tier user with 2 vehicles: No dialog, app loads - [ ] Pro/Enterprise tier user: No dialog, app loads - [ ] Dialog cannot be dismissed without selection - [ ] Selected vehicles saved correctly - [ ] Mobile + desktop responsive validation ## Acceptance Criteria from Issue - [x] Backend endpoint returns correct `needsSelection` status - [x] VehicleSelectionDialog shown automatically on login when needed - [x] Dialog cannot be dismissed without making selection - [x] Selected vehicles saved correctly - [ ] Mobile + desktop responsive validation (manual testing needed) --- 🤖 Generated with [Claude Code](https://claude.com/claude-code)
egullickson added 4 commits 2026-01-24 17:32:02 +00:00
feat: add needs-vehicle-selection endpoint (refs #60) 684615a8a2 
- Add GET /api/subscriptions/needs-vehicle-selection endpoint
- Returns { needsSelection, vehicleCount, maxAllowed }
- Checks: free tier, >2 vehicles, no existing selections

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
feat: add needsVehicleSelection frontend hook (refs #60) baf576f5cb 
- Add NeedsVehicleSelectionResponse type
- Add needsVehicleSelection API method
- Add useNeedsVehicleSelection hook with staleTime: 0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
feat: add blocking mode to VehicleSelectionDialog (refs #60) de7aa8c13c 
- Add blocking prop to prevent dismissal
- Disable backdrop click and escape key when blocking
- Hide Cancel button in blocking mode
- Update messaging for auto-downgrade scenario

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
feat: integrate vehicle selection dialog on login (refs #60)
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 6m42s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 30s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 7s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
b06a5e692b 
- Add useNeedsVehicleSelection and useVehicles hooks in App.tsx
- Show blocking VehicleSelectionDialog after auth gate ready
- Call downgrade API on confirm to save vehicle selections
- Invalidate queries after selection to proceed to app

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
egullickson added 1 commit 2026-01-24 17:51:48 +00:00
fix: filter locked vehicles after tier downgrade selection (refs #60)
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 2m38s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 29s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
68948484a4 
- GET /api/vehicles now uses getUserVehiclesWithTierStatus() and filters
  out vehicles with tierStatus='locked' so only selected vehicles appear
  in the vehicle list
- GET /api/vehicles/:id now checks tier status and returns 403 TIER_REQUIRED
  if user tries to access a locked vehicle directly

This ensures that after a user selects 2 vehicles during downgrade to
free tier, only those 2 vehicles appear in the summary and details screens.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
egullickson merged commit a97c9e2579 into main 2026-01-24 17:56:24 +00:00
egullickson deleted branch issue-60-vehicle-selection-prompt 2026-01-24 17:56:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#62
Delete Branch "issue-60-vehicle-selection-prompt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?