egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Fuel Logs API 500 error - repository snake_case mismatch (#47) #48

Merged
egullickson merged 2 commits from issue-47-fix-fuel-logs-api into main 2026-01-18 04:33:03 +00:00
Conversation 0 Commits 2 Files Changed 10 +1803 -40
egullickson commented 2026-01-18 04:08:44 +00:00
Owner
Copy Link

Summary

  • Fix enhanced repository methods returning mapped (camelCase) rows instead of raw database rows (snake_case)
  • Service's toEnhancedResponse() expects snake_case, causing RangeError: Invalid time value on new Date(row.created_at)
  • Removed mapRow() calls from all enhanced repository methods

Root Cause

The enhanced repository methods (findByUserIdEnhanced, findByVehicleIdEnhanced, etc.) were incorrectly calling this.mapRow() which converts snake_case database columns to camelCase TypeScript properties. However, the service's toEnhancedResponse() method expects raw database rows with snake_case properties.

When toEnhancedResponse() tried new Date(row.created_at).toISOString() with row.created_at being undefined (because mapRow converted it to createdAt), it threw RangeError: Invalid time value.

Changes

Fixed 7 methods in fuel-logs.repository.ts:

  • createEnhanced (line 296)
  • findByVehicleIdEnhanced (line 304)
  • findByUserIdEnhanced (line 312)
  • findByIdEnhanced (line 317)
  • getPreviousLogByOdometer (line 325)
  • getLatestLogForVehicle (line 333)
  • updateEnhanced (line 419)

Test Plan

  • Backend type-check passes
  • Backend lint passes
  • CI/CD pipeline passes
  • Verify fuel logs page loads on staging
  • Verify adding fuel log entry works

Fixes #47

## Summary - Fix enhanced repository methods returning mapped (camelCase) rows instead of raw database rows (snake_case) - Service's `toEnhancedResponse()` expects snake_case, causing `RangeError: Invalid time value` on `new Date(row.created_at)` - Removed `mapRow()` calls from all enhanced repository methods ## Root Cause The enhanced repository methods (`findByUserIdEnhanced`, `findByVehicleIdEnhanced`, etc.) were incorrectly calling `this.mapRow()` which converts snake_case database columns to camelCase TypeScript properties. However, the service's `toEnhancedResponse()` method expects raw database rows with snake_case properties. When `toEnhancedResponse()` tried `new Date(row.created_at).toISOString()` with `row.created_at` being `undefined` (because mapRow converted it to `createdAt`), it threw `RangeError: Invalid time value`. ## Changes Fixed 7 methods in `fuel-logs.repository.ts`: - `createEnhanced` (line 296) - `findByVehicleIdEnhanced` (line 304) - `findByUserIdEnhanced` (line 312) - `findByIdEnhanced` (line 317) - `getPreviousLogByOdometer` (line 325) - `getLatestLogForVehicle` (line 333) - `updateEnhanced` (line 419) ## Test Plan - [x] Backend type-check passes - [x] Backend lint passes - [ ] CI/CD pipeline passes - [ ] Verify fuel logs page loads on staging - [ ] Verify adding fuel log entry works Fixes #47
egullickson added 1 commit 2026-01-18 04:08:45 +00:00
fix: return raw rows from enhanced repository methods (refs #47)
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 2m28s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 29s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 7s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
574acf3e87 
Enhanced repository methods were incorrectly calling mapRow() which
converts snake_case to camelCase, but the service's toEnhancedResponse()
expects raw database rows with snake_case properties. This caused
"Invalid time value" errors when calling new Date(row.created_at).

Fixed methods:
- createEnhanced
- findByVehicleIdEnhanced
- findByUserIdEnhanced
- findByIdEnhanced
- getPreviousLogByOdometer
- getLatestLogForVehicle
- updateEnhanced

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
egullickson added 1 commit 2026-01-18 04:27:29 +00:00
chore: updates
All checks were successful
Deploy to Staging / Build Images (pull_request) Successful in 3m49s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 29s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 7s
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 6s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Has been skipped
Details
444abf2255
egullickson merged commit 33c88e7591 into main 2026-01-18 04:33:03 +00:00
egullickson deleted branch issue-47-fix-fuel-logs-api 2026-01-18 04:33:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#48
Delete Branch "issue-47-fix-fuel-logs-api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?