egullickson/motovaultpro
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: add role agent definitions with pinned models (#248) #249

Merged
egullickson merged 1 commits from issue-248-add-role-agents into main 2026-08-23 13:23:40 +00:00
Conversation 0 Commits 1 Files Changed 7
+167 -1
egullickson commented 2026-08-22 23:26:23 +00:00
Owner
Copy Link
Copy Source

Summary

  • Adds five role agent definitions under .claude/agents/ (developer, debugger, quality-reviewer, operator, tech-writer), each with a frontmatter model: pin - sonnet for the worker roles, opus for quality-reviewer - restoring the cost/speed model enforcement lost when c239bb9 deleted enforce-agent-model.sh and the old role-agent library.
  • Each agent's prompt directs it to read the relevant .claude/skills/mvp-*/SKILL.md files before acting, keeping the skill library as the single source of domain knowledge. quality-reviewer is additionally restricted to a read-only toolset (Read, Grep, Glob, Bash).
  • Doc-sync: adds an Agents index table to .claude/CLAUDE.md and updates the .claude/ row in root CLAUDE.md.
  • Companion local-only fix (gitignored, not in this diff): removed the dangling enforce-agent-model.sh PreToolUse hook from .claude/settings.local.json, which fired a nonexistent command on every subagent spawn.

Linked issues

Type

  • Chore / refactor

Test plan

  • Unit tests
  • Integration tests
  • Manual verification

Commands / steps:

  1. Markdown/config-only change - no application code touched, so workspace lint/type-check/test gates do not apply.
  2. Verified every .claude/skills/mvp-*/SKILL.md path referenced in the agent prompts resolves to an existing file (15 unique paths, all present).
  3. Verified frontmatter of all five agents contains name, description, model (and tools for quality-reviewer).
  4. Agent definitions are picked up at session start; model pins take effect when work is delegated via the Task tool.

Screenshots / UI notes (if applicable)

N/A - no UI change.

Checklist

  • Acceptance criteria met (from linked issue)
  • No secrets committed
  • Logging is appropriate (no PII)
  • Docs updated (if needed)

🤖 Generated with Claude Code

## Summary - Adds five role agent definitions under `.claude/agents/` (developer, debugger, quality-reviewer, operator, tech-writer), each with a frontmatter `model:` pin - sonnet for the worker roles, opus for quality-reviewer - restoring the cost/speed model enforcement lost when c239bb9 deleted `enforce-agent-model.sh` and the old role-agent library. - Each agent's prompt directs it to read the relevant `.claude/skills/mvp-*/SKILL.md` files before acting, keeping the skill library as the single source of domain knowledge. quality-reviewer is additionally restricted to a read-only toolset (`Read, Grep, Glob, Bash`). - Doc-sync: adds an Agents index table to `.claude/CLAUDE.md` and updates the `.claude/` row in root `CLAUDE.md`. - Companion local-only fix (gitignored, not in this diff): removed the dangling `enforce-agent-model.sh` PreToolUse hook from `.claude/settings.local.json`, which fired a nonexistent command on every subagent spawn. ## Linked issues - Fixes #248 ## Type - [x] Chore / refactor ## Test plan - [ ] Unit tests - [ ] Integration tests - [x] Manual verification **Commands / steps:** 1. Markdown/config-only change - no application code touched, so workspace lint/type-check/test gates do not apply. 2. Verified every `.claude/skills/mvp-*/SKILL.md` path referenced in the agent prompts resolves to an existing file (15 unique paths, all present). 3. Verified frontmatter of all five agents contains `name`, `description`, `model` (and `tools` for quality-reviewer). 4. Agent definitions are picked up at session start; model pins take effect when work is delegated via the Task tool. ## Screenshots / UI notes (if applicable) N/A - no UI change. ## Checklist - [x] Acceptance criteria met (from linked issue) - [x] No secrets committed - [x] Logging is appropriate (no PII) - [x] Docs updated (if needed) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
egullickson added 1 commit 2026-08-22 23:26:24 +00:00
chore: add role agent definitions with pinned models (refs #248)
Deploy to Staging / Build Images (pull_request) Successful in 4m33s
Details
Deploy to Staging / Deploy to Staging (pull_request) Successful in 45s
Details
Deploy to Staging / Verify Staging (pull_request) Successful in 3s
Details
Deploy to Staging / Notify Staging Failure (pull_request) Skipped
Details
Deploy to Staging / Notify Staging Ready (pull_request) Successful in 3s
Details
b601dcd5ce 
Adds five role agents under .claude/agents/, each pinned to a model in
frontmatter (sonnet for developer/debugger/operator/tech-writer, opus
for quality-reviewer) and directed to read the relevant mvp-* skills
before acting. Replaces the model enforcement lost when c239bb9 deleted
enforce-agent-model.sh. Updates .claude/CLAUDE.md and root CLAUDE.md
indexes.

Co-Authored-By: Claude Fable 5 <[email protected]>
egullickson merged commit 5fb5ff965c into main 2026-08-23 13:23:40 +00:00
egullickson deleted branch issue-248-add-role-agents 2026-08-23 13:23:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#249