egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Update frontend and tests for Gemini VIN decode (#223) #228

New Issue
Closed
opened 2026-02-19 03:19:48 +00:00 by egullickson · 0 comments
egullickson commented 2026-02-19 03:19:48 +00:00
Owner
Copy Link

Relates to #223

Scope

Update frontend types and components to use sourceValue instead of nhtsaValue, and update all test files.

Frontend Changes

  • Rename nhtsaValue to sourceValue in frontend/src/features/vehicles/types/vehicles.types.ts
  • Update VinOcrReviewModal.tsx references to use sourceValue
  • Update comments referencing NHTSA in frontend vehicle files
  • Update guide page sections if they reference NHTSA

Test Changes

  • Update backend/src/features/vehicles/tests/integration/vehicles.integration.test.ts
  • Add/update unit tests for VIN decode via OCR service flow
  • Verify existing OCR tests are unaffected

Acceptance Criteria

  • Frontend compiles with zero NHTSA references
  • VinOcrReviewModal works with sourceValue field
  • All tests pass (npm test)
  • Existing OCR image-based VIN extraction unaffected
Relates to #223 ## Scope Update frontend types and components to use `sourceValue` instead of `nhtsaValue`, and update all test files. ### Frontend Changes - Rename `nhtsaValue` to `sourceValue` in `frontend/src/features/vehicles/types/vehicles.types.ts` - Update `VinOcrReviewModal.tsx` references to use `sourceValue` - Update comments referencing NHTSA in frontend vehicle files - Update guide page sections if they reference NHTSA ### Test Changes - Update `backend/src/features/vehicles/tests/integration/vehicles.integration.test.ts` - Add/update unit tests for VIN decode via OCR service flow - Verify existing OCR tests are unaffected ### Acceptance Criteria - [ ] Frontend compiles with zero NHTSA references - [ ] VinOcrReviewModal works with sourceValue field - [ ] All tests pass (npm test) - [ ] Existing OCR image-based VIN extraction unaffected
egullickson added the
status
backlog
type
feature
 labels 2026-02-19 03:20:05 +00:00
egullickson added
status
done
 and removed
status
backlog
 labels 2026-02-20 15:04:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No Label
status
done
type
feature
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?