egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: remove redundant Stations entry from mobile More menu (#162) #173

New Issue
Closed
opened 2026-02-13 22:24:08 +00:00 by egullickson · 2 comments
egullickson commented 2026-02-13 22:24:08 +00:00
Owner
Copy Link

Relates to #162

Severity: Medium

Problem

The bottom nav on mobile shows "Stations" and the "More" menu also shows "Stations". This is redundant. The "More" menu should only show pages NOT already in the bottom nav.

Acceptance Criteria

  • "Stations" appears only once in mobile navigation (either bottom nav or More menu, not both)
  • All pages remain reachable from mobile navigation
  • Tested on mobile (320px, 768px)
Relates to #162 ## Severity: Medium ## Problem The bottom nav on mobile shows "Stations" and the "More" menu also shows "Stations". This is redundant. The "More" menu should only show pages NOT already in the bottom nav. ## Acceptance Criteria - "Stations" appears only once in mobile navigation (either bottom nav or More menu, not both) - All pages remain reachable from mobile navigation - Tested on mobile (320px, 768px)
egullickson added the
status
backlog
type
chore
 labels 2026-02-13 22:24:40 +00:00
egullickson added this to the Sprint 2026-02-02 milestone 2026-02-13 22:24:58 +00:00
egullickson commented 2026-02-14 01:14:56 +00:00
Author
Owner
Copy Link

Implementation Plan (from #162 -- Milestone 4)

Phase: 2 (Navigation cleanup) | Priority: Medium | Depends on: None | Blocks: None

Context

Stations is accessible via the bottom nav bar but also appears redundantly in the hamburger "More" menu. This duplication is confusing.

Implementation

1. In frontend/src/shared-minimal/components/mobile/HamburgerDrawer.tsx:

  • Remove the { screen: 'Stations', label: 'Stations', icon: <LocalGasStationRoundedIcon /> } entry from the menuItems array
  • Stations remains accessible via bottom nav

Files

  • frontend/src/shared-minimal/components/mobile/HamburgerDrawer.tsx

Commit Convention

chore: remove redundant Stations from mobile More menu (refs #173)

Test Criteria

  • Stations does NOT appear in the More (hamburger) menu
  • Stations IS still accessible via bottom navigation bar
  • All other pages remain reachable
  • Verify on mobile (320px, 768px) viewports

Branch

Work on branch issue-162-ux-design-audit-cleanup (shared with all #162 sub-issues)

## Implementation Plan (from #162 -- Milestone 4) **Phase**: 2 (Navigation cleanup) | **Priority**: Medium | **Depends on**: None | **Blocks**: None ### Context Stations is accessible via the bottom nav bar but also appears redundantly in the hamburger "More" menu. This duplication is confusing. ### Implementation **1. In `frontend/src/shared-minimal/components/mobile/HamburgerDrawer.tsx`:** - Remove the `{ screen: 'Stations', label: 'Stations', icon: <LocalGasStationRoundedIcon /> }` entry from the `menuItems` array - Stations remains accessible via bottom nav ### Files - `frontend/src/shared-minimal/components/mobile/HamburgerDrawer.tsx` ### Commit Convention ``` chore: remove redundant Stations from mobile More menu (refs #173) ``` ### Test Criteria - Stations does NOT appear in the More (hamburger) menu - Stations IS still accessible via bottom navigation bar - All other pages remain reachable - Verify on mobile (320px, 768px) viewports ### Branch Work on branch `issue-162-ux-design-audit-cleanup` (shared with all #162 sub-issues)
egullickson added
status
in-progress
 and removed
status
backlog
 labels 2026-02-14 01:38:57 +00:00
egullickson commented 2026-02-14 01:39:20 +00:00
Author
Owner
Copy Link

Milestone: Implementation Complete

Phase: Execution | Agent: Developer | Status: PASS

Changes

  • Removed { screen: 'Stations', ... } entry from menuItems array in HamburgerDrawer.tsx
  • Stations remains accessible via bottom navigation bar

Verification

  • TypeScript type-check: PASS
  • ESLint: PASS (no new warnings)
  • Commit: 7a74c7f on branch issue-162-ux-design-audit-cleanup

Updated Menu Order (bottom-to-top)

Settings, Documents, Maintenance, Log Fuel, Vehicles, Dashboard

Verdict: PASS | Next: Visual verification on mobile viewports

## Milestone: Implementation Complete **Phase**: Execution | **Agent**: Developer | **Status**: PASS ### Changes - Removed `{ screen: 'Stations', ... }` entry from `menuItems` array in `HamburgerDrawer.tsx` - Stations remains accessible via bottom navigation bar ### Verification - TypeScript type-check: PASS - ESLint: PASS (no new warnings) - Commit: `7a74c7f` on branch `issue-162-ux-design-audit-cleanup` ### Updated Menu Order (bottom-to-top) Settings, Documents, Maintenance, Log Fuel, Vehicles, Dashboard *Verdict*: PASS | *Next*: Visual verification on mobile viewports
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No Label
status
in-progress
type
chore
Milestone
No items
No Milestone Sprint 2026-02-02
Projects
Clear projects
No project
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#173
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?