egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Diagnose and fix crop tool regression (#115) #120

New Issue
Closed
opened 2026-02-07 16:13:12 +00:00 by egullickson · 0 comments
egullickson commented 2026-02-07 16:13:12 +00:00
Owner
Copy Link

Relates to #115

The free-form crop tool is reported as non-functional after PR #114 merge. Diagnose the root cause and fix.

Investigation Notes

Code review of CropTool.tsx and useImageCrop.ts shows a standard handle-based crop tool that appears functional. The regression may be:

  1. A runtime issue not visible from code review (mobile touch events, container sizing)
  2. An integration issue between CameraCapture state machine and CropTool
  3. A specific mobile browser issue (iOS Safari)

Changes

  • Diagnose crop tool regression with runtime testing
  • Fix the identified issue in frontend/src/shared/components/CameraCapture/
  • Verify crop works on mobile (iOS Safari) and desktop (Chrome)
  • Verify VIN scanning end-to-end: camera -> crop -> OCR -> decode -> form population

Acceptance Criteria

  • Crop tool functional on desktop Chrome
  • Crop tool functional on mobile iOS Safari
  • VIN scanning end-to-end works with crop
  • File upload fallback works with crop
Relates to #115 The free-form crop tool is reported as non-functional after PR #114 merge. Diagnose the root cause and fix. ## Investigation Notes Code review of CropTool.tsx and useImageCrop.ts shows a standard handle-based crop tool that appears functional. The regression may be: 1. A runtime issue not visible from code review (mobile touch events, container sizing) 2. An integration issue between CameraCapture state machine and CropTool 3. A specific mobile browser issue (iOS Safari) ## Changes - Diagnose crop tool regression with runtime testing - Fix the identified issue in `frontend/src/shared/components/CameraCapture/` - Verify crop works on mobile (iOS Safari) and desktop (Chrome) - Verify VIN scanning end-to-end: camera -> crop -> OCR -> decode -> form population ## Acceptance Criteria - [ ] Crop tool functional on desktop Chrome - [ ] Crop tool functional on mobile iOS Safari - [ ] VIN scanning end-to-end works with crop - [ ] File upload fallback works with crop
egullickson added the
status
backlog
type
bug
 labels 2026-02-07 16:13:25 +00:00
egullickson added this to the Sprint 2026-02-02 milestone 2026-02-07 16:13:33 +00:00
egullickson added
status
in-progress
 and removed
status
backlog
 labels 2026-02-07 17:19:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
status
backlog
status/blocked
status
done
status
in-progress
status
ready
status
review
type
bug
type
chore
type
docs
type
feature
No Label
status
in-progress
type
bug
Milestone
No items
No Milestone Sprint 2026-02-02
Projects
Clear projects
No project
Assignees
Clear assignees
egullickson
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: egullickson/motovaultpro#120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?