Homepage Redesign

backend/src/features/vehicles/tests/unit/vehicles.service.test.ts

@@ -5,17 +5,19 @@
 
 import { VehiclesService } from '../../domain/vehicles.service';
 import { VehiclesRepository } from '../../data/vehicles.repository';
-import { vpicClient } from '../../external/vpic/vpic.client';
 import { cacheService } from '../../../../core/config/redis';
+import * as platformModule from '../../../platform';
 
 // Mock dependencies
 jest.mock('../../data/vehicles.repository');
-jest.mock('../../external/vpic/vpic.client');
 jest.mock('../../../../core/config/redis');
+jest.mock('../../../platform', () => ({
+  getVINDecodeService: jest.fn()
+}));
 
 const mockRepository = jest.mocked(VehiclesRepository);
-const mockVpicClient = jest.mocked(vpicClient);
 const mockCacheService = jest.mocked(cacheService);
+const mockGetVINDecodeService = jest.mocked(platformModule.getVINDecodeService);
 
 describe('VehiclesService', () => {
   let service: VehiclesService;
@@ -23,7 +25,7 @@ describe('VehiclesService', () => {
 
   beforeEach(() => {
     jest.clearAllMocks();
-    
+
     repositoryInstance = {
       create: jest.fn(),
       findByUserId: jest.fn(),
@@ -31,8 +33,6 @@ describe('VehiclesService', () => {
       findByUserAndVIN: jest.fn(),
       update: jest.fn(),
       softDelete: jest.fn(),
-      cacheVINDecode: jest.fn(),
-      getVINFromCache: jest.fn(),
     } as any;
 
     mockRepository.mockImplementation(() => repositoryInstance);
@@ -74,16 +74,27 @@ describe('VehiclesService', () => {
     };
 
     it('should create a vehicle with VIN decoding', async () => {
+      const mockVinDecodeService = {
+        decodeVIN: jest.fn().mockResolvedValue({
+          success: true,
+          data: {
+            vin: '1HGBH41JXMN109186',
+            make: 'Honda',
+            model: 'Civic',
+            year: 2021
+          }
+        })
+      };
+      mockGetVINDecodeService.mockReturnValue(mockVinDecodeService as any);
+
       repositoryInstance.findByUserAndVIN.mockResolvedValue(null);
-      mockVpicClient.decodeVIN.mockResolvedValue(mockVinDecodeResult);
       repositoryInstance.create.mockResolvedValue(mockCreatedVehicle);
-      repositoryInstance.cacheVINDecode.mockResolvedValue(undefined);
       mockCacheService.del.mockResolvedValue(undefined);
 
       const result = await service.createVehicle(mockVehicleData, 'user-123');
 
       expect(repositoryInstance.findByUserAndVIN).toHaveBeenCalledWith('user-123', '1HGBH41JXMN109186');
-      expect(mockVpicClient.decodeVIN).toHaveBeenCalledWith('1HGBH41JXMN109186');
+      expect(mockVinDecodeService.decodeVIN).toHaveBeenCalledWith('1HGBH41JXMN109186');
       expect(repositoryInstance.create).toHaveBeenCalledWith({
         ...mockVehicleData,
         userId: 'user-123',
@@ -91,7 +102,6 @@ describe('VehiclesService', () => {
         model: 'Civic',
         year: 2021,
       });
-      expect(repositoryInstance.cacheVINDecode).toHaveBeenCalledWith('1HGBH41JXMN109186', mockVinDecodeResult);
       expect(result.id).toBe('vehicle-id-123');
       expect(result.make).toBe('Honda');
     });
@@ -109,8 +119,15 @@ describe('VehiclesService', () => {
     });
 
     it('should handle VIN decode failure gracefully', async () => {
+      const mockVinDecodeService = {
+        decodeVIN: jest.fn().mockResolvedValue({
+          success: false,
+          error: 'VIN decode failed'
+        })
+      };
+      mockGetVINDecodeService.mockReturnValue(mockVinDecodeService as any);
+
       repositoryInstance.findByUserAndVIN.mockResolvedValue(null);
-      mockVpicClient.decodeVIN.mockResolvedValue(null);
       repositoryInstance.create.mockResolvedValue({ ...mockCreatedVehicle, make: undefined, model: undefined, year: undefined });
       mockCacheService.del.mockResolvedValue(undefined);