From c27959f04598c78b3995e073032f3a6cd0102ccf Mon Sep 17 00:00:00 2001
From: Eric Gullickson <16152721+ericgullickson@users.noreply.github.com>
Date: Wed, 31 Dec 2025 16:07:32 -0600
Subject: [PATCH] fix: edit buttons

---
 docs/E2E-TESTING.md                           | 10 +++
 docs/PROMPTS.md                               |  6 +-
 frontend/src/App.tsx                          | 63 ++++++++++++++++++-
 .../vehicles/mobile/VehicleDetailMobile.tsx   | 14 ++++-
 .../vehicles/pages/VehicleDetailPage.tsx      | 17 ++++-
 .../features/vehicles/pages/VehiclesPage.tsx  |  2 +-
 6 files changed, 100 insertions(+), 12 deletions(-)
 create mode 100644 docs/E2E-TESTING.md

diff --git a/docs/E2E-TESTING.md b/docs/E2E-TESTING.md
new file mode 100644
index 0000000..702b9ed
--- /dev/null
+++ b/docs/E2E-TESTING.md
@@ -0,0 +1,10 @@
+ Test scenarios to verify:
+
+  | Test                    | Year | VIN                | License Plate | Expected                  |
+  |-------------------------|------|--------------------|---------------|---------------------------|
+  | 1. Edit bug fix         | Any  | null (existing)    | "TEST-123"    | Should save without error |
+  | 2. Modern + VIN only    | 2020 | Valid 17-char      | Empty         | Should work               |
+  | 3. Modern + plate only  | 2020 | Empty              | "ABC-123"     | Should work               |
+  | 4. Modern + neither     | 2020 | Empty              | Empty         | Should fail validation    |
+  | 5. Pre-1981 + neither   | 1970 | Empty              | Empty         | Should work               |
+  | 6. Pre-1981 + short VIN | 1965 | "ABC123" (6 chars) | Empty         | Should work               |
\ No newline at end of file
diff --git a/docs/PROMPTS.md b/docs/PROMPTS.md
index a6d362b..f8a1464 100644
--- a/docs/PROMPTS.md
+++ b/docs/PROMPTS.md
@@ -30,10 +30,8 @@ You are a senior software engineer specializsing in NodeJS, Typescript, front en
 *** CHANGES TO IMPLEMENT ***
 - Research this code base and ask iterative questions to compile a complete plan.
 - We will pair troubleshoot this. Tell me what logs and things to run and I will 
-- There is a bug in the ability to add and edit vehicles
-- Change it so the every vehicle older than 1981 does not have a 17 digit VIN requirement.
-- Verify the edit logic. When I had a license plate but no VIN, it still said the VIN was required. 
-
+- There is a bug in the vehicles screen
+- The pencil icon on the vehicle cards does not take you to the edit screen. It does nothing. 
 
 
 
diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx
index 36f79b0..05a1292 100644
--- a/frontend/src/App.tsx
+++ b/frontend/src/App.tsx
@@ -265,6 +265,50 @@ const AddVehicleScreen: React.FC<AddVehicleScreenProps> = ({ onBack, onAdded })
   );
 };
 
+interface EditVehicleScreenProps {
+  vehicle: Vehicle;
+  onBack: () => void;
+  onUpdated: () => void;
+}
+
+const EditVehicleScreen: React.FC<EditVehicleScreenProps> = ({ vehicle, onBack, onUpdated }) => {
+  const queryClient = useQueryClient();
+
+  const handleUpdateVehicle = async (data: CreateVehicleRequest) => {
+    try {
+      const { vehiclesApi } = await import('./features/vehicles/api/vehicles.api');
+      await vehiclesApi.update(vehicle.id, data);
+      queryClient.invalidateQueries({ queryKey: ['vehicles'] });
+      onUpdated();
+    } catch (error) {
+      console.error('Failed to update vehicle:', error);
+    }
+  };
+
+  return (
+    <div className="space-y-4">
+      <GlassCard>
+        <div className="p-4">
+          <div className="flex items-center justify-between mb-4">
+            <h2 className="text-lg font-semibold text-slate-800">Edit Vehicle</h2>
+            <button
+              onClick={onBack}
+              className="p-2 hover:bg-gray-100 rounded-full transition-colors"
+            >
+              ✕
+            </button>
+          </div>
+          <VehicleForm
+            initialData={vehicle}
+            onSubmit={handleUpdateVehicle}
+            onCancel={onBack}
+          />
+        </div>
+      </GlassCard>
+    </div>
+  );
+};
+
 function App() {
   const { isLoading, isAuthenticated, user } = useAuth0();
   const location = useLocation();
@@ -440,6 +484,16 @@ function App() {
     navigateToVehicleSubScreen('list', undefined, { source: 'vehicle-added' });
   }, [navigateToVehicleSubScreen]);
 
+  const handleEditVehicle = useCallback(() => {
+    if (selectedVehicle) {
+      navigateToVehicleSubScreen('edit', selectedVehicle.id, { source: 'vehicle-detail' });
+    }
+  }, [navigateToVehicleSubScreen, selectedVehicle]);
+
+  const handleVehicleUpdated = useCallback(() => {
+    navigateToVehicleSubScreen('detail', selectedVehicle?.id, { source: 'vehicle-updated' });
+  }, [navigateToVehicleSubScreen, selectedVehicle]);
+
   // Enhanced debug component
   const DebugInfo = () => (
     <MobileDebugPanel visible={import.meta.env.MODE === 'development'} />
@@ -602,11 +656,18 @@ function App() {
                 <MobileErrorBoundary screenName="Vehicles">
                   {vehicleSubScreen === 'add' || showAddVehicle ? (
                     <AddVehicleScreen onBack={handleBackToList} onAdded={handleVehicleAdded} />
-                  ) : selectedVehicle && (vehicleSubScreen === 'detail') ? (
+                  ) : selectedVehicle && vehicleSubScreen === 'edit' ? (
+                    <EditVehicleScreen
+                      vehicle={selectedVehicle}
+                      onBack={handleBackToList}
+                      onUpdated={handleVehicleUpdated}
+                    />
+                  ) : selectedVehicle && vehicleSubScreen === 'detail' ? (
                     <VehicleDetailMobile
                       vehicle={selectedVehicle}
                       onBack={handleBackToList}
                       onLogFuel={() => navigateToScreen("Log Fuel")}
+                      onEdit={handleEditVehicle}
                     />
                   ) : (
                     <VehiclesMobileScreen
diff --git a/frontend/src/features/vehicles/mobile/VehicleDetailMobile.tsx b/frontend/src/features/vehicles/mobile/VehicleDetailMobile.tsx
index 2e64239..9847f20 100644
--- a/frontend/src/features/vehicles/mobile/VehicleDetailMobile.tsx
+++ b/frontend/src/features/vehicles/mobile/VehicleDetailMobile.tsx
@@ -16,6 +16,7 @@ interface VehicleDetailMobileProps {
   vehicle: Vehicle;
   onBack: () => void;
   onLogFuel?: () => void;
+  onEdit?: () => void;
 }
 
 const Section: React.FC<{ title: string; children: React.ReactNode }> = ({
@@ -33,7 +34,8 @@ const Section: React.FC<{ title: string; children: React.ReactNode }> = ({
 export const VehicleDetailMobile: React.FC<VehicleDetailMobileProps> = ({
   vehicle,
   onBack,
-  onLogFuel
+  onLogFuel,
+  onEdit
 }) => {
   const displayName = vehicle.nickname || 
     [vehicle.year, vehicle.make, vehicle.model, vehicle.trimLevel].filter(Boolean).join(' ') || 'Vehicle';
@@ -168,9 +170,15 @@ export const VehicleDetailMobile: React.FC<VehicleDetailMobileProps> = ({
         </Box>
       </Box>
       
-      <Box sx={{ display: 'flex', gap: 1.5, mb: 3 }}>
-        <Button 
+      <Box sx={{ display: 'flex', gap: 1.5, mb: 3, flexWrap: 'wrap' }}>
+        <Button
           variant="contained"
+          onClick={onEdit}
+        >
+          Edit Vehicle
+        </Button>
+        <Button
+          variant="outlined"
           onClick={onLogFuel}
         >
           Add Fuel
diff --git a/frontend/src/features/vehicles/pages/VehicleDetailPage.tsx b/frontend/src/features/vehicles/pages/VehicleDetailPage.tsx
index dbcaa19..8a5e7f9 100644
--- a/frontend/src/features/vehicles/pages/VehicleDetailPage.tsx
+++ b/frontend/src/features/vehicles/pages/VehicleDetailPage.tsx
@@ -3,7 +3,7 @@
  */
 
 import React, { useMemo, useState, useEffect } from 'react';
-import { useParams, useNavigate } from 'react-router-dom';
+import { useParams, useNavigate, useSearchParams } from 'react-router-dom';
 import { Box, Typography, Button as MuiButton, Divider, FormControl, InputLabel, Select, MenuItem, Table, TableHead, TableRow, TableCell, TableBody, Dialog, DialogTitle, DialogContent, useMediaQuery } from '@mui/material';
 import { useQueryClient } from '@tanstack/react-query';
 import ArrowBackIcon from '@mui/icons-material/ArrowBack';
@@ -43,9 +43,10 @@ const DetailField: React.FC<{
 export const VehicleDetailPage: React.FC = () => {
   const { id } = useParams<{ id: string }>();
   const navigate = useNavigate();
+  const [searchParams, setSearchParams] = useSearchParams();
   const [vehicle, setVehicle] = useState<Vehicle | null>(null);
   const [isLoading, setIsLoading] = useState(true);
-  const [isEditing, setIsEditing] = useState(false);
+  const [isEditing, setIsEditing] = useState(() => searchParams.get('edit') === 'true');
   const [error, setError] = useState<string | null>(null);
   const [recordFilter, setRecordFilter] = useState<'All' | 'Fuel Logs' | 'Maintenance' | 'Documents'>('All');
 
@@ -139,11 +140,16 @@ export const VehicleDetailPage: React.FC = () => {
 
   const handleUpdateVehicle = async (data: any) => {
     if (!vehicle) return;
-    
+
     try {
       const updatedVehicle = await vehiclesApi.update(vehicle.id, data);
       setVehicle(updatedVehicle);
       setIsEditing(false);
+      // Clear the edit query param from URL
+      if (searchParams.has('edit')) {
+        searchParams.delete('edit');
+        setSearchParams(searchParams, { replace: true });
+      }
     } catch (err) {
       console.error('Error updating vehicle:', err);
     }
@@ -151,6 +157,11 @@ export const VehicleDetailPage: React.FC = () => {
 
   const handleCancelEdit = () => {
     setIsEditing(false);
+    // Clear the edit query param from URL
+    if (searchParams.has('edit')) {
+      searchParams.delete('edit');
+      setSearchParams(searchParams, { replace: true });
+    }
   };
 
   if (isLoading) {
diff --git a/frontend/src/features/vehicles/pages/VehiclesPage.tsx b/frontend/src/features/vehicles/pages/VehiclesPage.tsx
index 10ac5e8..c060903 100644
--- a/frontend/src/features/vehicles/pages/VehiclesPage.tsx
+++ b/frontend/src/features/vehicles/pages/VehiclesPage.tsx
@@ -215,7 +215,7 @@ export const VehiclesPage: React.FC = () => {
             <Grid item xs={12} md={6} lg={4} key={vehicle.id}>
               <VehicleCard
                 vehicle={vehicle}
-                onEdit={(v) => console.log('Edit', v)}
+                onEdit={(v) => navigate(`/garage/vehicles/${v.id}?edit=true`)}
                 onDelete={handleDelete}
                 onSelect={handleSelectVehicle}
               />