egullickson/motovaultpro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: add migration and nullable types for stripe_customer_id (refs #207)

Browse Source 
Make stripe_customer_id NULLABLE via migration, clean up admin_override_*
values to NULL, and update Subscription/SubscriptionResponse/UpdateSubscriptionData
types in both backend and frontend.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Eric Gullickson
2026-02-16 09:28:46 -06:00
parent ddae397cb3
commit af11b49e26
3 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
backend/src/features/subscriptions/domain/subscriptions.types.ts
View File

@@ -19,7 +19,7 @@ export type DonationStatus = 'pending' | 'succeeded' | 'failed' | 'canceled';
export interface Subscription { export interface Subscription {
id: string; id: string;
userId: string; userId: string;
stripeCustomerId: string; stripeCustomerId: string | null;
stripeSubscriptionId?: string; stripeSubscriptionId?: string;
tier: SubscriptionTier; tier: SubscriptionTier;
billingCycle?: BillingCycle; billingCycle?: BillingCycle;
@@ -74,7 +74,7 @@ export interface CreateSubscriptionRequest {
export interface SubscriptionResponse { export interface SubscriptionResponse {
id: string; id: string;
userId: string; userId: string;
stripeCustomerId: string; stripeCustomerId: string | null;
stripeSubscriptionId?: string; stripeSubscriptionId?: string;
tier: SubscriptionTier; tier: SubscriptionTier;
billingCycle?: BillingCycle; billingCycle?: BillingCycle;
@@ -118,7 +118,7 @@ export interface CreateTierVehicleSelectionRequest {
// Service layer types // Service layer types
export interface UpdateSubscriptionData { export interface UpdateSubscriptionData {
stripeCustomerId?: string; stripeCustomerId?: string | null;
stripeSubscriptionId?: string; stripeSubscriptionId?: string;
tier?: SubscriptionTier; tier?: SubscriptionTier;
billingCycle?: BillingCycle; billingCycle?: BillingCycle;

11
backend/src/features/subscriptions/migrations/002_nullable_stripe_customer_id.sql Normal file
View File

@@ -0,0 +1,11 @@
-- Migration: Make stripe_customer_id NULLABLE
-- Removes the NOT NULL constraint that forced admin_override_ placeholder values.
-- Admin-set subscriptions (no Stripe billing) use NULL instead of sentinel strings.
-- PostgreSQL UNIQUE constraint allows multiple NULLs (SQL standard).
-- Drop NOT NULL constraint on stripe_customer_id
ALTER TABLE subscriptions ALTER COLUMN stripe_customer_id DROP NOT NULL;
-- Clean up existing admin_override_ placeholder values to NULL
UPDATE subscriptions SET stripe_customer_id = NULL
WHERE stripe_customer_id LIKE 'admin_override_%';

2
frontend/src/features/subscription/types/subscription.types.ts
View File

@@ -5,7 +5,7 @@ export type SubscriptionStatus = 'active' | 'past_due' | 'canceled' | 'unpaid';
export interface Subscription { export interface Subscription {
id: string; id: string;
userId: string; userId: string;
stripeCustomerId: string; stripeCustomerId: string | null;
stripeSubscriptionId?: string; stripeSubscriptionId?: string;
tier: SubscriptionTier; tier: SubscriptionTier;
billingCycle?: BillingCycle; billingCycle?: BillingCycle;