Possible working ETL

backend/src/features/vehicles/tests/unit/vehicles.service.test.ts

@@ -12,14 +12,12 @@ import * as platformModule from '../../../platform';
 jest.mock('../../data/vehicles.repository');
 jest.mock('../../../../core/config/redis');
 jest.mock('../../../platform', () => ({
-  getVINDecodeService: jest.fn(),
   getVehicleDataService: jest.fn(),
   getPool: jest.fn()
 }));
 
 const mockRepository = jest.mocked(VehiclesRepository);
 const mockCacheService = jest.mocked(cacheService);
-const mockGetVINDecodeService = jest.mocked(platformModule.getVINDecodeService);
 const mockGetVehicleDataService = jest.mocked(platformModule.getVehicleDataService);
 const mockGetPool = jest.mocked(platformModule.getPool);
 
@@ -117,7 +115,7 @@ describe('VehiclesService', () => {
       ]);
     });
   });
-});
+
   describe('createVehicle', () => {
     const mockVehicleData = {
       vin: '1HGBH41JXMN109186',
@@ -126,22 +124,13 @@ describe('VehiclesService', () => {
       odometerReading: 50000,
     };
 
-    const mockVinDecodeResult = {
-      make: 'Honda',
-      model: 'Civic',
-      year: 2021,
-      engineType: '2.0L',
-      bodyType: 'Sedan',
-      rawData: [],
-    };
-
     const mockCreatedVehicle = {
       id: 'vehicle-id-123',
       userId: 'user-123',
       vin: '1HGBH41JXMN109186',
-      make: 'Honda',
-      model: 'Civic',
-      year: 2021,
+      make: undefined,
+      model: undefined,
+      year: undefined,
       nickname: 'My Car',
       color: 'Blue',
       licensePlate: undefined,
@@ -152,20 +141,7 @@ describe('VehiclesService', () => {
       updatedAt: new Date('2024-01-01T00:00:00Z'),
     };
 
-    it('should create a vehicle with VIN decoding', async () => {
-      const mockVinDecodeService = {
-        decodeVIN: jest.fn().mockResolvedValue({
-          success: true,
-          data: {
-            vin: '1HGBH41JXMN109186',
-            make: 'Honda',
-            model: 'Civic',
-            year: 2021
-          }
-        })
-      };
-      mockGetVINDecodeService.mockReturnValue(mockVinDecodeService as any);
-
+    it('should create a vehicle with user-provided VIN', async () => {
       repositoryInstance.findByUserAndVIN.mockResolvedValue(null);
       repositoryInstance.create.mockResolvedValue(mockCreatedVehicle);
       mockCacheService.del.mockResolvedValue(undefined);
@@ -173,16 +149,13 @@ describe('VehiclesService', () => {
       const result = await service.createVehicle(mockVehicleData, 'user-123');
 
       expect(repositoryInstance.findByUserAndVIN).toHaveBeenCalledWith('user-123', '1HGBH41JXMN109186');
-      expect(mockVinDecodeService.decodeVIN).toHaveBeenCalledWith('mock-pool', '1HGBH41JXMN109186');
       expect(repositoryInstance.create).toHaveBeenCalledWith({
         ...mockVehicleData,
         userId: 'user-123',
-        make: 'Honda',
-        model: 'Civic',
-        year: 2021,
+        make: undefined,
+        model: undefined,
       });
       expect(result.id).toBe('vehicle-id-123');
-      expect(result.make).toBe('Honda');
     });
 
     it('should reject invalid VIN format', async () => {
@@ -196,31 +169,6 @@ describe('VehiclesService', () => {
 
       await expect(service.createVehicle(mockVehicleData, 'user-123')).rejects.toThrow('Vehicle with this VIN already exists');
     });
-
-    it('should handle VIN decode failure gracefully', async () => {
-      const mockVinDecodeService = {
-        decodeVIN: jest.fn().mockResolvedValue({
-          success: false,
-          error: 'VIN decode failed'
-        })
-      };
-      mockGetVINDecodeService.mockReturnValue(mockVinDecodeService as any);
-
-      repositoryInstance.findByUserAndVIN.mockResolvedValue(null);
-      repositoryInstance.create.mockResolvedValue({ ...mockCreatedVehicle, make: undefined, model: undefined, year: undefined });
-      mockCacheService.del.mockResolvedValue(undefined);
-
-      const result = await service.createVehicle(mockVehicleData, 'user-123');
-
-      expect(repositoryInstance.create).toHaveBeenCalledWith({
-        ...mockVehicleData,
-        userId: 'user-123',
-        make: undefined,
-        model: undefined,
-        year: undefined,
-      });
-      expect(result.make).toBeUndefined();
-    });
   });
 
   describe('getUserVehicles', () => {