Possible working ETL

backend/src/features/vehicles/domain/vehicles.service.ts

@@ -4,7 +4,6 @@
  */
 
 import { VehiclesRepository } from '../data/vehicles.repository';
-import { getVINDecodeService, getVehicleDataService, getPool } from '../../platform';
 import {
   Vehicle,
   CreateVehicleRequest,
@@ -15,6 +14,7 @@ import { logger } from '../../../core/logging/logger';
 import { cacheService } from '../../../core/config/redis';
 import { isValidVIN } from '../../../shared-minimal/utils/validators';
 import { normalizeMakeName, normalizeModelName } from './name-normalizer';
+import { getVehicleDataService, getPool } from '../../platform';
 
 export class VehiclesService {
   private readonly cachePrefix = 'vehicles';
@@ -27,10 +27,6 @@ export class VehiclesService {
   async createVehicle(data: CreateVehicleRequest, userId: string): Promise<VehicleResponse> {
     logger.info('Creating vehicle', { userId, vin: data.vin, licensePlate: (data as any).licensePlate });
 
-    let make: string | undefined;
-    let model: string | undefined;
-    let year: number | undefined;
-
     if (data.vin) {
       // Validate VIN if provided
       if (!isValidVIN(data.vin)) {
@@ -41,33 +37,19 @@ export class VehiclesService {
       if (existing) {
         throw new Error('Vehicle with this VIN already exists');
       }
-      // Attempt VIN decode to enrich fields using platform service
-      const vinDecodeService = getVINDecodeService();
-      const pool = getPool();
-      const vinDecodeResult = await vinDecodeService.decodeVIN(pool, data.vin);
-      if (vinDecodeResult.success && vinDecodeResult.result) {
-        make = normalizeMakeName(vinDecodeResult.result.make);
-        model = normalizeModelName(vinDecodeResult.result.model);
-        year = vinDecodeResult.result.year ?? undefined;
-        // VIN caching is now handled by platform feature
-      }
     }
-    
-    // Create vehicle (VIN optional). Client-sent make/model/year override decode if provided.
-    const inputMake = (data as any).make ?? make;
-    const inputModel = (data as any).model ?? model;
 
+    // Create vehicle with user-provided data
     const vehicle = await this.repository.create({
       ...data,
       userId,
-      make: normalizeMakeName(inputMake),
-      model: normalizeModelName(inputModel),
-      year: (data as any).year ?? year,
+      make: data.make ? normalizeMakeName(data.make) : undefined,
+      model: data.model ? normalizeModelName(data.model) : undefined,
     });
-    
+
     // Invalidate user's vehicle list cache
     await this.invalidateUserCache(userId);
-    
+
     return this.toResponse(vehicle);
   }
   
@@ -178,12 +160,12 @@ export class VehiclesService {
     return vehicleDataService.getModels(pool, year, make);
   }
 
-  async getDropdownTransmissions(year: number, make: string, model: string): Promise<string[]> {
+  async getDropdownTransmissions(year: number, make: string, model: string, trim: string): Promise<string[]> {
     const vehicleDataService = getVehicleDataService();
     const pool = getPool();
 
-    logger.info('Fetching dropdown transmissions via platform module', { year, make, model });
-    return vehicleDataService.getTransmissions(pool, year, make, model);
+    logger.info('Fetching dropdown transmissions via platform module', { year, make, model, trim });
+    return vehicleDataService.getTransmissionsForTrim(pool, year, make, model, trim);
   }
 
   async getDropdownEngines(year: number, make: string, model: string, trim: string): Promise<string[]> {
@@ -202,6 +184,21 @@ export class VehiclesService {
     return vehicleDataService.getTrims(pool, year, make, model);
   }
 
+  async getDropdownOptions(
+    year: number,
+    make: string,
+    model: string,
+    trim: string,
+    engine?: string,
+    transmission?: string
+  ): Promise<{ engines: string[]; transmissions: string[] }> {
+    const vehicleDataService = getVehicleDataService();
+    const pool = getPool();
+
+    logger.info('Fetching dropdown options via platform module', { year, make, model, trim, engine, transmission });
+    return vehicleDataService.getOptions(pool, year, make, model, trim, engine, transmission);
+  }
+
   async getDropdownYears(): Promise<number[]> {
     const vehicleDataService = getVehicleDataService();
     const pool = getPool();
@@ -210,54 +207,6 @@ export class VehiclesService {
     return vehicleDataService.getYears(pool);
   }
 
-  async decodeVIN(vin: string): Promise<{
-    vin: string;
-    success: boolean;
-    year?: number;
-    make?: string;
-    model?: string;
-    trimLevel?: string;
-    engine?: string;
-    transmission?: string;
-    confidence?: number;
-    error?: string;
-  }> {
-    try {
-      logger.info('Decoding VIN', { vin });
-
-      // Use platform feature's VIN decode service
-      const vinDecodeService = getVINDecodeService();
-      const pool = getPool();
-      const result = await vinDecodeService.decodeVIN(pool, vin);
-
-      if (result.success && result.result) {
-        return {
-          vin,
-          success: true,
-          year: result.result.year ?? undefined,
-          make: result.result.make ?? undefined,
-          model: result.result.model ?? undefined,
-          trimLevel: result.result.trim_name ?? undefined,
-          engine: result.result.engine_description ?? undefined,
-          confidence: 85 // High confidence since we have good data
-        };
-      } else {
-        return {
-          vin,
-          success: false,
-          error: result.error || 'Unable to decode VIN'
-        };
-      }
-    } catch (error) {
-      logger.error('Failed to decode VIN', { vin, error });
-      return {
-        vin,
-        success: false,
-        error: 'VIN decode service unavailable'
-      };
-    }
-  }
-
   private toResponse(vehicle: Vehicle): VehicleResponse {
     return {
       id: vehicle.id,