Possible working ETL

backend/src/features/vehicles/api/vehicles.controller.ts

@@ -12,6 +12,8 @@ import { CreateVehicleBody, UpdateVehicleBody, VehicleParams } from '../domain/v
 
 export class VehiclesController {
   private vehiclesService: VehiclesService;
+  private static readonly MIN_YEAR = 2017;
+  private static readonly MAX_YEAR = 2022;
 
   constructor() {
     const repository = new VehiclesRepository(pool);
@@ -153,10 +155,10 @@ export class VehiclesController {
   async getDropdownMakes(request: FastifyRequest<{ Querystring: { year: number } }>, reply: FastifyReply) {
     try {
       const { year } = request.query;
-      if (!year || year < 1980 || year > new Date().getFullYear() + 1) {
+      if (!year || year < VehiclesController.MIN_YEAR || year > VehiclesController.MAX_YEAR) {
         return reply.code(400).send({
           error: 'Bad Request',
-          message: 'Valid year parameter is required (1980-' + (new Date().getFullYear() + 1) + ')'
+          message: `Valid year parameter is required (${VehiclesController.MIN_YEAR}-${VehiclesController.MAX_YEAR})`
         });
       }
       
@@ -174,10 +176,10 @@ export class VehiclesController {
   async getDropdownModels(request: FastifyRequest<{ Querystring: { year: number; make: string } }>, reply: FastifyReply) {
     try {
       const { year, make } = request.query;
-      if (!year || !make || year < 1980 || year > new Date().getFullYear() + 1 || make.trim().length === 0) {
+      if (!year || !make || year < VehiclesController.MIN_YEAR || year > VehiclesController.MAX_YEAR || make.trim().length === 0) {
         return reply.code(400).send({
           error: 'Bad Request',
-          message: 'Valid year and make parameters are required'
+          message: `Valid year and make parameters are required (${VehiclesController.MIN_YEAR}-${VehiclesController.MAX_YEAR})`
         });
       }
 
@@ -192,20 +194,20 @@ export class VehiclesController {
     }
   }
 
-  async getDropdownTransmissions(request: FastifyRequest<{ Querystring: { year: number; make: string; model: string } }>, reply: FastifyReply) {
+  async getDropdownTransmissions(request: FastifyRequest<{ Querystring: { year: number; make: string; model: string; trim: string } }>, reply: FastifyReply) {
     try {
-      const { year, make, model } = request.query;
-      if (!year || !make || !model || year < 1980 || year > new Date().getFullYear() + 1 || make.trim().length === 0 || model.trim().length === 0) {
+      const { year, make, model, trim } = request.query;
+      if (!year || !make || !model || !trim || year < VehiclesController.MIN_YEAR || year > VehiclesController.MAX_YEAR || make.trim().length === 0 || model.trim().length === 0 || trim.trim().length === 0) {
         return reply.code(400).send({
           error: 'Bad Request',
-          message: 'Valid year, make, and model parameters are required'
+          message: `Valid year, make, model, and trim parameters are required (${VehiclesController.MIN_YEAR}-${VehiclesController.MAX_YEAR})`
         });
       }
 
-      const transmissions = await this.vehiclesService.getDropdownTransmissions(year, make, model);
+      const transmissions = await this.vehiclesService.getDropdownTransmissions(year, make, model, trim);
       return reply.code(200).send(transmissions);
     } catch (error) {
-      logger.error('Error getting dropdown transmissions', { error, year: request.query?.year, make: request.query?.make, model: request.query?.model });
+      logger.error('Error getting dropdown transmissions', { error, year: request.query?.year, make: request.query?.make, model: request.query?.model, trim: request.query?.trim });
       return reply.code(500).send({
         error: 'Internal server error',
         message: 'Failed to get transmissions'
@@ -216,10 +218,10 @@ export class VehiclesController {
   async getDropdownEngines(request: FastifyRequest<{ Querystring: { year: number; make: string; model: string; trim: string } }>, reply: FastifyReply) {
     try {
       const { year, make, model, trim } = request.query;
-      if (!year || !make || !model || !trim || year < 1980 || year > new Date().getFullYear() + 1 || make.trim().length === 0 || model.trim().length === 0 || trim.trim().length === 0) {
+      if (!year || !make || !model || !trim || year < VehiclesController.MIN_YEAR || year > VehiclesController.MAX_YEAR || make.trim().length === 0 || model.trim().length === 0 || trim.trim().length === 0) {
         return reply.code(400).send({
           error: 'Bad Request',
-          message: 'Valid year, make, model, and trim parameters are required'
+          message: `Valid year, make, model, and trim parameters are required (${VehiclesController.MIN_YEAR}-${VehiclesController.MAX_YEAR})`
         });
       }
 
@@ -237,10 +239,10 @@ export class VehiclesController {
   async getDropdownTrims(request: FastifyRequest<{ Querystring: { year: number; make: string; model: string } }>, reply: FastifyReply) {
     try {
       const { year, make, model } = request.query;
-      if (!year || !make || !model || year < 1980 || year > new Date().getFullYear() + 1 || make.trim().length === 0 || model.trim().length === 0) {
+      if (!year || !make || !model || year < VehiclesController.MIN_YEAR || year > VehiclesController.MAX_YEAR || make.trim().length === 0 || model.trim().length === 0) {
         return reply.code(400).send({
           error: 'Bad Request',
-          message: 'Valid year, make, and model parameters are required'
+          message: `Valid year, make, and model parameters are required (${VehiclesController.MIN_YEAR}-${VehiclesController.MAX_YEAR})`
         });
       }
 
@@ -269,26 +271,23 @@ export class VehiclesController {
     }
   }
 
-  async decodeVIN(request: FastifyRequest<{ Body: { vin: string } }>, reply: FastifyReply) {
+  async getDropdownOptions(request: FastifyRequest<{ Querystring: { year: number; make: string; model: string; trim: string; engine?: string; transmission?: string } }>, reply: FastifyReply) {
     try {
-      const { vin } = request.body;
-      
-      if (!vin || vin.length !== 17) {
+      const { year, make, model, trim, engine, transmission } = request.query;
+      if (!year || !make || !model || !trim || year < VehiclesController.MIN_YEAR || year > VehiclesController.MAX_YEAR || make.trim().length === 0 || model.trim().length === 0 || trim.trim().length === 0) {
         return reply.code(400).send({
-          vin: vin || '',
-          success: false,
-          error: 'VIN must be exactly 17 characters'
+          error: 'Bad Request',
+          message: `Valid year, make, model, and trim parameters are required (${VehiclesController.MIN_YEAR}-${VehiclesController.MAX_YEAR})`
         });
       }
-      
-      const result = await this.vehiclesService.decodeVIN(vin);
-      return reply.code(200).send(result);
-    } catch (error: any) {
-      logger.error('Error decoding VIN', { error, vin: request.body?.vin });
+
+      const options = await this.vehiclesService.getDropdownOptions(year, make, model, trim, engine, transmission);
+      return reply.code(200).send(options);
+    } catch (error) {
+      logger.error('Error getting dropdown options', { error, query: request.query });
       return reply.code(500).send({
-        vin: request.body?.vin || '',
-        success: false,
-        error: 'VIN decode failed'
+        error: 'Internal server error',
+        message: 'Failed to get engine/transmission options'
       });
     }
   }